Safe Git Commit & PR

PROJ-142 login flow: commit and PR prep

Branch: feature/PROJ-142-login-flow → main

Gaps found in the diff

The login route is never registered. src/auth/login.route.ts exports handleLogin, but src/server.ts only handles /health. So POST /api/v1/login, which the form calls, gets a 404.
2.

**Every login fails.** The route passes `async () => null` as `findUser`, so the user is never found and every attempt returns 401.
3.

The token is a placeholder. It's a base64 of id:timestamp with a TODO to switch to a signed JWT, so anyone could forge it. JWT_SECRET exists in .env but nothing uses it.
4.

Migration 003 isn't used. The code tracks attempts in an in-memory Map, so the count resets on restart, never expires, and isn't shared between instances. The login_attempts table is never written.
5. Error handling:

• Any error that isn't bad credentials, such as a DB failure, returns 429.
• JSON.parse runs outside the try, so malformed JSON is never caught.
• The form does nothing on success and doesn't catch network errors.
• Locking out by email alone means anyone can lock out any account by sending 5 bad passwords.

Decision: commit as work in progress (option a).

Files

Planned commits (each needs your OK before it runs)

1. .gitignore (waiting for your OK)

chore: ignore env files, build output and logs

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2. Auth service, route and form

feat(auth): add login endpoint and form submission (PROJ-142)

Work in progress: the route is not yet registered in server.ts, the
user lookup is stubbed, and the token is a placeholder until JWT
signing is added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

3. Migration

feat(db): add login_attempts table migration (PROJ-142)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

PR description draft

Follows .github/pull_request_template.md.

## Summary
Adds the login flow for PROJ-142: the login service checks credentials and limits attempts, there is a `POST /api/v1/login` handler, and the login form submits to it. **Work in progress:** the endpoint is not reachable yet and does not issue real tokens (see Risks).

## Changes
**Backend**
- `auth.service.ts`: `login()` takes a `findUser` lookup, checks the password, and throws `InvalidCredentialsError` when they don't match. It blocks after 5 failed attempts per email (in-memory) and returns `{ token, user }`.
- `login.route.ts`: new `handleLogin` handler. Returns 200 on success, 401 for bad credentials, 429 otherwise.

**Frontend**
- `login-form.tsx`: posts to `/api/v1/login` and shows an error alert when the request fails.

**Database** (run in this order)
1. `003_add_login_attempts.sql`: `login_attempts` table plus an `(email, attempted_at)` index. The code doesn't use it yet.

## How to test
Not fully testable end-to-end yet: the route isn't registered, so `POST /api/v1/login` returns 404.
- Unit-level: call `login()` with a stub `findUser`. Check that a correct password returns a token, a wrong one throws `InvalidCredentialsError`, and the 6th failure throws "Too many attempts".
- UI: submit the form and check that the error alert appears.

## Risks / deploy notes
- **Blocking before merge:**
  - `handleLogin` is not registered in `server.ts`.
  - `findUser` is stubbed to always return `null`.
  - The token is an unsigned placeholder (TODO: signed JWT using `JWT_SECRET`).
- Attempt limiting is in memory: it resets on restart, never expires, isn't shared across instances, and lets anyone lock out any account by email. Migration 003 is meant to replace it.
- Errors that aren't bad credentials (e.g. DB failures) return 429. Malformed JSON bodies aren't handled.
- New env vars will be needed per environment: `JWT_SECRET`, `DATABASE_URL`.
- Migration 003 adds a new table. Rolling back means dropping `login_attempts`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)